Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: Fix warning and treat them as errors #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 15, 2020
Merged

docs: Fix warning and treat them as errors #666

merged 4 commits into from
May 15, 2020

Conversation

mauriciovasquezbernal
Copy link
Member

The CI is not able to catch many documentation problems because we are ignoring
warnings. This commit fixes most of the warnings, ignores the rest and enables
a flag to treat them as errors.

@mauriciovasquezbernal mauriciovasquezbernal added the doc Documentation-related label May 8, 2020
@mauriciovasquezbernal mauriciovasquezbernal requested a review from a team May 8, 2020 23:35
@mauriciovasquezbernal
Copy link
Member Author

Hey @ocelotl, any reason for the changes you force-pushed? (https://github.com/open-telemetry/opentelemetry-python/compare/b48140334138f92f2b9c9c837a1d6573e9c0e361..3d343c50c04410f53fb4817eeba270149e250f60)

It seems to me we are using a single tab to wrap those lines: https://github.com/open-telemetry/opentelemetry-python/blob/master/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py

@ocelotl
Copy link
Contributor

ocelotl commented May 11, 2020

Hey @ocelotl, any reason for the changes you force-pushed? (https://github.com/open-telemetry/opentelemetry-python/compare/b48140334138f92f2b9c9c837a1d6573e9c0e361..3d343c50c04410f53fb4817eeba270149e250f60)

It seems to me we are using a single tab to wrap those lines: https://github.com/open-telemetry/opentelemetry-python/blob/master/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py

Hey @mauriciovasquezbernal !

Yes, I force pushed this PR because it needed a few updates, it had conflicts and such.

Funny thing, I tried to use 4 spaces and got an error when running tox -e docs, so I tried aligning with the argument before. I must have made some mistake because I tried using 4 spaces again and it is not showing any more errors 🤔, updating now.

@ocelotl ocelotl self-assigned this May 11, 2020
c24t
c24t approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mauriciovasquezbernal!

codeboten
codeboten approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocelotl ocelotl changed the title docs: Fix warning and threat them as errors docs: Fix warning and treat them as errors May 12, 2020
mauriciovasquezbernal and others added 4 commits May 14, 2020 11:44
@mauriciovasquezbernal @ocelotl
docs: Fix warning and threat them as errors
9038f97 
The CI is not able to catch many documentation problems because we are ignoring
warnings. This commit fixes most of the warnings, ignores the rest and enables
a flag to treat them as errors.
@ocelotl
Use 4 spaces instead
20170be
@ocelotl
Fix environment variable reference
bd9a2b5
Merge branch 'master' into mauricio/fix-sphinx-warnings
2c305b9
@codeboten codeboten merged commit 34a9616 into open-telemetry:master May 15, 2020
cnnradams pushed a commit to cnnradams/opentelemetry-python that referenced this pull request May 15, 2020
@mauriciovasquezbernal @ocelotl @cnnradams
docs: Fix warning and treat them as errors (open-telemetry#666)
8c3f7c6 
The CI is not able to catch many documentation problems because we are ignoring
warnings. This commit fixes most of the warnings, ignores the rest and enables
a flag to treat them as errors.

Co-authored-by: Diego Hurtado <[email protected]>
owais pushed a commit to owais/opentelemetry-python that referenced this pull request May 22, 2020
@mauriciovasquezbernal @ocelotl @owais
docs: Fix warning and treat them as errors (open-telemetry#666)
a2c06eb 
The CI is not able to catch many documentation problems because we are ignoring
warnings. This commit fixes most of the warnings, ignores the rest and enables
a flag to treat them as errors.

Co-authored-by: Diego Hurtado <[email protected]>
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@vmarchaud
feat: add express plugin open-telemetry#666 (open-telemetry#685)
5e0d2c9 
* feat: add express plugin open-telemetry#666

* feat: set http.route attribute on http server span if possible

* feat: add config to ignore express layers

* chore: add documentation about express layer store
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@c24t c24t c24t approved these changes

Assignees

@ocelotl ocelotl

Labels
doc Documentation-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mauriciovasquezbernal @ocelotl @codeboten @c24t