Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Chore: Drop support for Python 3.8 #3399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

Chore: Drop support for Python 3.8 #3399

merged 1 commit into from
May 27, 2025

Conversation

jomcgi
Copy link
Contributor

@jomcgi jomcgi commented Apr 1, 2025 •
edited
Loading

Description

Python 3.8 was EoL @ 2024-10-07, our 6 month promise for support will end @ 2024-04-07.

Changes:

  • Removed all 3.8 references, updated basline refs to 3.9
  • Removed 3.8 sys.version_info checks
  • Fixed botocore test failure
  • Applied ruff formatting

Fixes open-telemetry/opentelemetry-python#4513

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Tested locally with tox
  • Tested in CI

Does This PR Require a Core Repo Change?

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@jomcgi jomcgi mentioned this pull request Apr 1, 2025
Merged
12 tasks
@jomcgi jomcgi force-pushed the chore-4513/drop-py38-support branch from 26c0f26 to 71eb61e Compare April 1, 2025 20:49
jomcgi
jomcgi commented Apr 1, 2025
View reviewed changes
@jomcgi jomcgi force-pushed the chore-4513/drop-py38-support branch 2 times, most recently from fba15e8 to e2360f6 Compare April 1, 2025 22:44
jomcgi
jomcgi commented Apr 1, 2025
View reviewed changes
@jomcgi jomcgi force-pushed the chore-4513/drop-py38-support branch from e2360f6 to 4f57fa3 Compare April 1, 2025 23:00
@jomcgi jomcgi force-pushed the chore-4513/drop-py38-support branch from 4f57fa3 to 415fb0c Compare April 4, 2025 08:33
jomcgi
jomcgi commented Apr 4, 2025
View reviewed changes
jomcgi
jomcgi commented Apr 4, 2025
View reviewed changes
@jomcgi jomcgi force-pushed the chore-4513/drop-py38-support branch 2 times, most recently from 5e91bf0 to cbac8ca Compare April 4, 2025 09:07
xrmx
xrmx reviewed Apr 11, 2025
View reviewed changes
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have preferred to decouple bumping the baseline to the changes to the other hundreds of files 😅

@jomcgi
Copy link
Contributor Author

jomcgi commented Apr 11, 2025

I would have preferred to decouple bumping the baseline to the changes to the other hundreds of files 😅

Agree - it's why this is still in draft.
Most of the type changes can be submitted separately, this definitely doesn't need to be coupled.

@jomcgi jomcgi force-pushed the chore-4513/drop-py38-support branch 3 times, most recently from 81f758e to b5dbc7b Compare April 16, 2025 08:24
@jomcgi jomcgi force-pushed the chore-4513/drop-py38-support branch from b5dbc7b to 7af57d4 Compare April 16, 2025 08:38
@jomcgi jomcgi changed the title [WIP] Chore: Drop support for Python 3.8 Chore: Drop support for Python 3.8 Apr 16, 2025
@jomcgi jomcgi marked this pull request as ready for review April 16, 2025 08:46
@jomcgi jomcgi requested a review from a team as a code owner April 16, 2025 08:46
@jomcgi jomcgi mentioned this pull request Apr 16, 2025
Open
xrmx
xrmx reviewed Apr 17, 2025
View reviewed changes
emdneto
emdneto reviewed Apr 17, 2025
View reviewed changes
emdneto
emdneto reviewed Apr 29, 2025
View reviewed changes
Copy link
Member

@emdneto emdneto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jomcgi I think we need to merge this first, and then merge -core. Do you think the -core PR is ready to review?

I'm fine with this PR once the comments are addressed.

@jomcgi jomcgi force-pushed the chore-4513/drop-py38-support branch 3 times, most recently from 44b2f31 to b012adf Compare May 25, 2025 21:25
@jomcgi
Chore: Drop support for Python 3.8
983847a 
Python 3.8 was EoL @ 2024-10-07, our 6 month promise for support ended on 2024-04-07.

Changes:
* Updated basline refs to 3.9
* Removed 3.8 sys.version_info checks
* Fixed botocore test failure
* Applied ruff formatting
@jomcgi jomcgi force-pushed the chore-4513/drop-py38-support branch from b012adf to 983847a Compare May 25, 2025 22:08
@jomcgi
Copy link
Contributor Author

jomcgi commented May 25, 2025 •
edited
Loading

Resolved open comments & rebased PR.

Do you think the -core PR is ready to review?

No - I can start looking at it now that this is up to date.

@jomcgi jomcgi mentioned this pull request May 25, 2025
Open
@xrmx
Copy link
Contributor

xrmx commented May 27, 2025 •
edited
Loading

Note to self: before merging this we need to remove the 3.8 jobs from jobs required to have a green CI

UPDATE: Done, once merged need to add pypy-3.9 entries

@xrmx xrmx merged commit a164d37 into open-telemetry:main May 27, 2025
625 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimastbk dimastbk dimastbk left review comments

@xrmx xrmx xrmx approved these changes

@emdneto emdneto emdneto approved these changes

Assignees

@codefromthecrypt codefromthecrypt

@federicobond federicobond

@codeboten codeboten

@lmolkova lmolkova

@gyliu513 gyliu513

@lzchen lzchen

@NathanielRN NathanielRN

@karthikscale3 karthikscale3

@jomcgi jomcgi

@alizenhom alizenhom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.8