feat: adds helpers for KeyValue collection #3128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
551b271 to
9138953
Compare
9138953 to
438c5c6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3128 +/- ##
=======================================
+ Coverage 80.4% 80.6% +0.1%
=======================================
Files 126 126
Lines 22237 22232 -5
=======================================
+ Hits 17898 17935 +37
+ Misses 4339 4297 -42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
These look like convenience wrappers on top of existing APIs to cut down boilerplate. Not sure they belong in the core repo since they don’t add anything from the spec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # N/A
Design discussion issue (if applicable) # N/A
Changes
In my project, I found it overly verbose to create the
KeyValueslice inline for attributes. I hope this can simplify it and allow data types how they prefer to be attributed.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes