Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: use instrumentation schema URL on scope spans #3171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

fix: use instrumentation schema URL on scope spans #3171

merged 1 commit into from
Sep 17, 2025
+51 −1

Conversation

scottgerring
Copy link
Member

Fixes #3135
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.7%. Comparing base (159135c) to head (059d6de).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #3171   +/-   ##
=====================================
  Coverage   80.7%   80.7%           
=====================================
  Files        126     126           
  Lines      22286   22328   +42     
=====================================
+ Hits       17986   18028   +42     
  Misses      4300    4300

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lalitb
lalitb approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once format is fixed. Also, good to add test to validate it.

@scottgerring scottgerring force-pushed the bug/instrumentation-span branch from 4419c21 to 059d6de Compare September 17, 2025 15:51
@scottgerring scottgerring marked this pull request as ready for review September 17, 2025 15:52
@scottgerring scottgerring requested a review from a team as a code owner September 17, 2025 15:52
@scottgerring
Copy link
Member Author

@lalitb done!

@cijothomas cijothomas merged commit 9bd2c1b into open-telemetry:main Sep 17, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: invalid schema url value on scope spans when exporting with otlp exporter
3 participants
@scottgerring @lalitb @cijothomas