fix: show which file and why knowledge directory sync failed - #29507
Merged
tjbck merged 1 commit intoSep 12, 2026
Merged
Conversation
Syncing a knowledge base from a local directory only ever showed a generic "Error accessing directory" toast when a per-file read failed, and production builds strip console.error, so nothing else recorded the cause either. On Windows this hides a real Chromium bug where files with very long absolute paths throw a NotFoundError from the File System Access API, leaving no way to tell which file failed or why. Both per-file read paths (the directory picker and drag-and-drop) now wrap read failures with the file's relative path and the underlying browser error before they reach the toast, so the message actually names the file and the reason. Reuses the existing translated toast text instead of adding a new i18n key, so the fix doesn't orphan existing translations of that string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncing a knowledge base from a local directory only ever showed a generic "Error accessing directory" toast when a per-file read failed, and production builds strip console.error, so nothing else recorded the cause either. On Windows this hides a real Chromium bug where files with very long absolute paths throw a NotFoundError from the File System Access API, leaving no way to tell which file failed or why.
Both per-file read paths (the directory picker and drag-and-drop) now wrap read failures with the file's relative path and the underlying browser error before they reach the toast, so the message actually names the file and the reason. Reuses the existing translated toast text instead of adding a new i18n key, so the fix doesn't orphan existing translations of that string.
Contributor License Agreement