fix: use raw strings for the regex escapes in the knowledge filesystem - #29515
Merged
tjbck merged 1 commit intoSep 3, 2026
Merged
Conversation
The regex detection helpers wrote their backslash escapes in ordinary string literals, so Python reported six invalid escape sequences on import. They work today because Python leaves an unrecognised escape as its two characters, but that behaviour is deprecated and becomes a syntax error in a future release, at which point the knowledge filesystem tools stop importing at all. The literals are now raw, which is the same two characters with no warning. Pattern detection and normalisation are unchanged: verified identical output over every string up to length five drawn from the characters these helpers look at.
pujitha24
pushed a commit
to pujitha24/open-webui
that referenced
this pull request
Sep 5, 2026
open-webui#29515) The regex detection helpers wrote their backslash escapes in ordinary string literals, so Python reported six invalid escape sequences on import. They work today because Python leaves an unrecognised escape as its two characters, but that behaviour is deprecated and becomes a syntax error in a future release, at which point the knowledge filesystem tools stop importing at all. The literals are now raw, which is the same two characters with no warning. Pattern detection and normalisation are unchanged: verified identical output over every string up to length five drawn from the characters these helpers look at.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex detection helpers wrote their backslash escapes in ordinary string literals, so Python reported six invalid escape sequences on import. They work today because Python leaves an unrecognised escape as its two characters, but that behaviour is deprecated and becomes a syntax error in a future release, at which point the knowledge filesystem tools stop importing at all.
The literals are now raw, which is the same two characters with no warning. Pattern detection and normalisation are unchanged: verified identical output over every string up to length five drawn from the characters these helpers look at.
Contributor License Agreement