Remove plan from system skills #8374
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
shijie-oai
left a comment
There was a problem hiding this comment.
Left a small comment - everything else looks good
ae-openai
left a comment
There was a problem hiding this comment.
Also LGTM. Just think we should be sure to test the migration removes the old plan skill, on the prod build once we have it
codex-rs/core/tests/suite/skills.rs
Outdated
| }) | ||
| .with_pre_build_hook(|home| { | ||
| let system_skill_path = home.join("skills/.system/plan/SKILL.md"); | ||
| let system_skill_path = home |
Good call. Confirmed with local build (see below). Will re-populate plan in my local Before running local build: After running local build: |
Removes plan from system skills. It has been rewritten into
create-planfor evaluation and feedback: openai/skills#22