refactor: share semantic audit admission - #920
Draft
mldangelo-oai wants to merge 4 commits into
Draft
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Managed scans and Deep discovery currently admit audit output through separate paths. Share one small, single-attempt operation and the existing semantic parser so a completed process cannot turn an unfinished audit checkpoint into an accepted result. Accepted audits may still report partial or unknown coverage.
Stacked on #917 for the shared execution boundary.
Changes
Testing
Current head:
67d586dd699fc5a1cad9afe8f53845bd14ba5842. All five portable checks pass. In an isolated SDK-only dependency layout on Linux, the original policy-proof build fails to resolvezod/v4; the corrected generated build succeeds. The changed tracked script is byte-identical to the green reader version. This is bundling evidence, not native Windows execution.The preceding head
b2512b30b97e52377b67ffb63fa49bd1658e45d5has identical scan/runtime code and this full qualification on Linux, Node 24.20, CI-pinned Bun 1.3.14 and Git 2.43:build:ci, plugin source compatibility and its Node test suite.pnpm pack, followed by the unchanged package checker: installed SDK and physically standalone plugin checks passed. Archive SHA256:b63d8dd9603a714045cac76605893aeb69c5a74ff43937d1430225c02d868b29.Initial SDK failures were reproduced on the parent with a different Bun/Git toolchain and malformed enclosing Git metadata. Both complete runs above use the CI toolchain and a separate checkout. The first local package build followed linked dependency paths and failed the existing internal-reference check before installation; rebuilding the same source with physical local dependencies passed. Neither product checks nor assertions were weakened.
The original CI run failed in both Windows policy-proof helper bundles after the native primitives built successfully. The final build-only correction preserves those failures and leaves native verification to the new ordinary CI run.
Risk and rollout
Review and land after #917. This is an internal extraction with explicit artifact acceptance; it introduces no public flag, new dependency, migration or scheduler policy. Standalone bundling and helper import behavior are the main compatibility risks and have direct coverage. Native Windows/macOS CI remains to be observed for this exact PR. These deterministic checks do not establish scan quality, cost or latency equivalence.
Public disclosure review