Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do not cache the toolsList per default #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025

Conversation

mjakl
Copy link
Contributor

@mjakl mjakl commented Jun 19, 2025

This PR changes the default for cacheToolsList from true to false. The documentation makes is sound like the default is false (see https://openai.github.io/openai-agents-js/guides/mcp/#other-things-to-know), and enabling caching has some unwanted side effects, especially when working with multiple local stdio MCP servers.

Defaulting to false is the safer option.

Copy link

changeset-bot bot commented Jun 19, 2025

🦋 Changeset detected

Latest commit: 975a825

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@openai/agents-core Minor
@openai/agents-openai Minor
@openai/agents-realtime Minor
@openai/agents Patch
@openai/agents-extensions Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@seratch seratch added bug Something isn't working package:agents-core labels Jun 19, 2025
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. The default setting should be false. The Python SDK's default is false too.

@dkundel-openai dkundel-openai merged commit f61fd18 into openai:main Jun 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package:agents-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants