Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(*): types package should be devDependency for reduce package size #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sunrabbit123
Copy link

This pull request reorganizes the dependency structure for @types/ws across multiple packages, moving it from dependencies to devDependencies. The changes also ensure consistency in the pnpm-lock.yaml file to reflect this reorganization.

Dependency Reorganization:

Lockfile Consistency:

  • pnpm-lock.yaml: Updated the importers section to reflect the reclassification of @types/ws as a devDependency for both agents-extensions and agents-realtime packages. [1] [2] [3] [4]

Copy link

changeset-bot bot commented Jun 13, 2025

⚠️ No Changeset found

Latest commit: 2864b95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sunrabbit123 sunrabbit123 changed the title chore(*): types package should be devDependency chore(*): types package should be devDependency for reduce package size Jun 13, 2025
@seratch seratch requested a review from dkundel-openai June 13, 2025 04:49
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dkundel-openai
Copy link
Collaborator

This makes the TypeScript experience worse no? Especially for the Realtime package where the Websocket type would not be typed on the OpenAIRealtimeWebSocket class unless the user explicitly installs the types themselves?

@sunrabbit123
Copy link
Author

oh i miss it
Good point — that’s something I hadn’t considered.
Would you be open to introducing this tool for a simple test?

https://github.com/stackblitz-labs/pkg.pr.new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants