[3/n] Config and items for realtime #1070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2025
pakrym-oai
reviewed
Jul 11, 2025
|
|
||
|
|
||
| class RealtimeSessionConfig(TypedDict): | ||
| api_key: NotRequired[APIKeyOrKeyFunc] |
There was a problem hiding this comment.
this doesn't align with RunConfig where API key is property of the model/model provider
There was a problem hiding this comment.
it's optional, its also a property of the transport (equialent to model provider) here
pakrym-oai
reviewed
Jul 11, 2025
| threshold: NotRequired[float] | ||
|
|
||
|
|
||
| class RealtimeSessionConfig(TypedDict): |
There was a problem hiding this comment.
Should this be named model config to mirror non realtime?
There was a problem hiding this comment.
no its not a model config. But you're right that I should separate the model specific configs and the other stuff i plan to add to this (e.g. tracing)
pakrym-oai
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the TS version.