[5/n] OpenAI realtime transport impl #1072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2025
rm-openai
added a commit
that referenced
this pull request
Jul 11, 2025
Similar to the TS version. - Config is the things you can set on the session - Items are similar to responses items. I'm using an abstraction instead of reusing the ones in the openai SDK, to reduce the amount of work for other providers --- [//]: # (BEGIN SAPLING FOOTER) * #1074 * #1073 * #1072 * #1071 * __->__ #1070 * #1069 * #1068
9904b08 to
572eb7d
Compare
pakrym-oai
reviewed
Jul 11, 2025
| model: NotRequired[str] | ||
| """The model to use.""" | ||
|
|
||
| url: NotRequired[str] |
There was a problem hiding this comment.
This seems a bit too specific to OpenAI to be a part of abstraction. Or should be documented differently.
pakrym-oai
reviewed
Jul 11, 2025
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| async def send_event(self, event: RealtimeClientMessage) -> None: |
There was a problem hiding this comment.
Why is this method public? I assume the message is very specific to the underlying transport.
There was a problem hiding this comment.
so that you can send events that aren't necessarily public. Helps with custom implementations, as well as with our own realtime evolving quickly
pakrym-oai
reviewed
Jul 11, 2025
|
|
||
| await self._cancel_response() | ||
|
|
||
| elapsed_time_ms = (datetime.now() - self._audio_start_time).total_seconds() * 1000 |
There was a problem hiding this comment.
Why round to seconds here?
There was a problem hiding this comment.
it's not rounding. python mostly uses seconds for everything (it's stored as a float not an int so doesnt lose precision)
pakrym-oai
approved these changes
Jul 11, 2025
rm-openai
added a commit
that referenced
this pull request
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the openai realtime impl over websockets. Unlike the TS version, only supports websockets - no in browser stuff.