[6/n] RealtimeSession + events #1073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2025
pakrym-oai
reviewed
Jul 11, 2025
| """A listener for realtime session events.""" | ||
|
|
||
| @abc.abstractmethod | ||
| async def on_event(self, event: RealtimeSessionEvent) -> None: |
There was a problem hiding this comment.
why callback and not a streaming interface like in Runner?
There was a problem hiding this comment.
yeah this is bad, i will change
pakrym-oai
reviewed
Jul 11, 2025
Comment on lines
+90
to
+91
| transport: Literal["websocket"] | RealtimeSessionTransport = "websocket", | ||
| api_key: APIKeyOrKeyFunc | None = None, |
There was a problem hiding this comment.
I'm surprised the transport is top level and separated from the model.
If we'd like to support 3rd party models they'll have to come with whatever transport they support.
There was a problem hiding this comment.
yes true, combining them into model
pakrym-oai
approved these changes
Jul 11, 2025
rm-openai
added a commit
that referenced
this pull request
Jul 11, 2025
Similar to the TS version. - Config is the things you can set on the session - Items are similar to responses items. I'm using an abstraction instead of reusing the ones in the openai SDK, to reduce the amount of work for other providers --- [//]: # (BEGIN SAPLING FOOTER) * #1074 * #1073 * #1072 * #1071 * __->__ #1070 * #1069 * #1068
rm-openai
added a commit
that referenced
this pull request
Jul 11, 2025
rm-openai
added a commit
that referenced
this pull request
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RealtimeSession is like Runner, except for Realtime. It's also stateful and manages the conversation for you.