Convert MCP schemas to strict where possible #414
Merged
+202
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary: Towards #404. I made this configurable because it's not clear this is always a good thing to do. I also made it default to False because I'm not sure if this could cause errors. If it works out well, we can switch the default in the future as a small breaking changes ## Test Plan: Unit tests
pakrym-oai
approved these changes
Apr 1, 2025
pakrym-oai
reviewed
Apr 1, 2025
| class MCPConfig(TypedDict): | ||
| """Configuration for MCP servers.""" | ||
|
|
||
| convert_schemas_to_strict: NotRequired[bool] |
There was a problem hiding this comment.
It slightly feels like the wrong place to do this. IMO the MCP server should be responsible to declaring itself as strict.
There was a problem hiding this comment.
Assuming you mean the actual MCP server, then yes I agree. That is a more involved change though, since MCP servers adhere to a published spec.
I didn't add it to the MCP server class in the repo, because I think those should be very thin wrappers around the actual MCP server, in order to be reused in other places outside the agents SDK internals.
Gonna merge this - but if you think we should implement it differently ping me and we can revert/re-do it!
Lightblues
pushed a commit
to Lightblues/openai-agents-python
that referenced
this pull request
Apr 13, 2025
## Summary: Towards openai#404. I made this configurable because it's not clear this is always a good thing to do. I also made it default to False because I'm not sure if this could cause errors. If it works out well, we can switch the default in the future as a small breaking changes ## Test Plan: Unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Towards #404. I made this configurable because it's not clear this is always a good thing to do. I also made it default to False because I'm not sure if this could cause errors.
If it works out well, we can switch the default in the future as a small breaking changes
Test Plan:
Unit tests