Hosted MCP support #731
Merged
Hosted MCP support #731
+332
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2025
pakrym-oai
reviewed
May 21, 2025
| @@ -308,3 +358,13 @@ def decorator(real_func: ToolFunction[...]) -> FunctionTool: | |||
| return _create_function_tool(real_func) | |||
|
|
|||
| return decorator | |||
| return decorator | |||
There was a problem hiding this comment.
Pretty sure the first one should work :)
pakrym-oai
reviewed
May 21, 2025
| @@ -375,6 +409,34 @@ def process_model_response( | |||
| computer_actions.append( | |||
| ToolRunComputerAction(tool_call=output, computer_tool=computer_tool) | |||
| ) | |||
| elif isinstance(output, McpApprovalRequest): | |||
There was a problem hiding this comment.
nit: inconsistent MCP casing
There was a problem hiding this comment.
Comes from the SDK unfortunately. I gave the feedback but it wasnt taken into account
pakrym-oai
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.