Only start tracing worker thread on first span/trace #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym-oai
reviewed
Jun 2, 2025
| self._worker_thread = threading.Thread(target=self._run, daemon=True) | ||
| self._worker_thread.start() | ||
| # We lazily start the background worker thread the first time a span/trace is queued. | ||
| self._worker_thread: threading.Thread | None = None |
There was a problem hiding this comment.
Why not start a task + asyncio q, then you don't have an extra thread to worry about and you can start the task unconditionally
There was a problem hiding this comment.
Hmm I was thinking:
- small overhead in cases where there are no traces (the unconditional task would still be scheduled every poll_interval seconds, even though it doesnt have work)
- It wouldn't work super well in totally sync contexts
- cleaning up the asyncio task is kinda annoying imo
lmk if you feel like I should change, happy to.
pakrym-oai
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #796. Shouldn't start a busy waiting thread if there aren't any traces.
Test plan