Rename ContainerClient file upload methods to UploadContainerFile#1138
Conversation
Agent-Logs-Url: https://github.com/openai/openai-dotnet/sessions/abf4d5bf-a4df-457b-8f48-e3505c6344ab Co-authored-by: joseharriaga <[email protected]>
ContainerClient file upload methods to UploadContainerFile
|
@copilot Please revert the CHANGELOG for now. We will modify it later in a separate PR. |
|
@joseharriaga I've opened a new pull request, #1139, to work on those changes. Once the pull request is ready, I'll request review from you. |
…#1139) * Initial plan * Revert CHANGELOG.md changes Agent-Logs-Url: https://github.com/openai/openai-dotnet/sessions/a8c8f038-a66a-4a22-9467-318cc94a0ff0 Co-authored-by: joseharriaga <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: joseharriaga <[email protected]>
|
@copilot Sync to the latest from |
…nerclient-createcontainerfile Co-authored-by: joseharriaga <[email protected]>
Handled in
Synced this branch to the latest |
There was a problem hiding this comment.
Pull request overview
This PR renames the container file creation/upload protocol methods on ContainerClient from CreateContainerFile* to UploadContainerFile* to better match the library’s download/file semantics, and propagates that rename through TypeSpec customization, generated code, tests, and the exported public API baselines.
Changes:
- Renamed
ContainerClient.CreateContainerFile/CreateContainerFileAsynctoUploadContainerFile/UploadContainerFileAsyncvia TypeSpec@@clientName. - Regenerated the
ContainerClientimplementation and REST request factory to use the new method names. - Updated container tests and API baseline exports to reflect the renamed methods.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Containers/ContainerTests.cs | Updates tests to call UploadContainerFileAsync instead of CreateContainerFileAsync. |
| specification/client/containers.client.tsp | Applies TypeSpec @@clientName rename for the container file upload operation. |
| OpenAI/src/Generated/ContainerClient.RestClient.cs | Renames the generated request factory method to CreateUploadContainerFileRequest. |
| OpenAI/src/Generated/ContainerClient.cs | Renames the generated protocol methods to UploadContainerFile* and updates internal call sites. |
| api/OpenAI.netstandard2.0.cs | Updates exported public API baselines to remove CreateContainerFile* and add UploadContainerFile*. |
| api/OpenAI.net8.0.cs | Updates exported public API baselines to remove CreateContainerFile* and add UploadContainerFile*. |
| api/OpenAI.net10.0.cs | Updates exported public API baselines to remove CreateContainerFile* and add UploadContainerFile*. |
Agent-Logs-Url: https://github.com/openai/openai-dotnet/sessions/11ed0811-05ec-4fad-bf57-3fe961c47e30 Co-authored-by: joseharriaga <[email protected]>
This updates
ContainerClientto use upload-oriented naming for container file writes, aligning the API withDownloadContainerFileand the rest of the library’s file semantics. The change is limited to the container file upload surface and its generated/public API projections.API surface
CreateContainerFile→UploadContainerFileCreateContainerFileAsync→UploadContainerFileAsyncGenerated client updates
ContainerClientand its REST request factory to use the new method namesTests and docs
Example