Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add an = to <= check in embedding_utils #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2022
Merged

Add an = to <= check in embedding_utils #118

merged 1 commit into from
Aug 26, 2022

Conversation

hallacy
Copy link
Collaborator

@hallacy hallacy commented Aug 26, 2022

No description provided.

@hallacy hallacy mentioned this pull request Aug 26, 2022
Closed
ted-at-openai
ted-at-openai approved these changes Aug 26, 2022
View reviewed changes
Copy link
Collaborator

@ted-at-openai ted-at-openai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that 2048 is the correct limit, and it is. Error message from exceeding 2048 is vague: ... is not valid under any of the given schemas - 'input'. Change looks good to me.

@hallacy hallacy merged commit e51ae91 into main Aug 26, 2022
@hallacy hallacy deleted the hallacy/fix_embedding_utils branch August 26, 2022 17:31
cgayapr pushed a commit to cgayapr/openai-python that referenced this pull request Dec 14, 2024
@hallacy
Add an = to <= check in embedding_utils (openai#118)
5b0cbfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ted-at-openai ted-at-openai ted-at-openai approved these changes

@BorisPower BorisPower Awaiting requested review from BorisPower

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hallacy @ted-at-openai