Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove support for py <3.6, mypy, lots of cleanup #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 11, 2021
Merged

Conversation

rachellim
Copy link
Collaborator

@rachellim rachellim commented Jun 11, 2021

[This is a cherry-pick of all of madeleine's internal changes]

madeleineth and others added 5 commits June 11, 2021 12:22
- Formally require Python 3.6 or later. This never worked under Python 2.7.
- Drop now-unnecessary `__future__` and `six` references.
- Use `py.typed` to declare that we support type hints.
- Fix a variety of mypy errors.
- Don't use star imports, so that other packages can tell if they're making an invalid reference.
- Drop support for non-`requests` HTTP clients.
- Drop `EngineAPIResource.update`; it could never have worked.

Tested against primaryapi and engineapi in staging, and it doesn't break them. After this, `mypy ./openai` runs clean.
- Delete `ListObject`. It has some typing errors that suggest it never worked, and it is unused as far as I can tell.
- Delete `VerifyMixin`. It is unused.
- Delete `CardError`. It is unused and smells of rotten pasta.
- Delete `OpenAIErrorWithParamCode`, which only has one subclass, `InvalidRequestError`, and make `InvalidRequestError` a direct subclass of `OpenAIError`. Currrently, `OpenAIErrorWithParamCode` depends on the internal structure of `InvalidRequestError` so they're not independent.
These are another step towards being able to enforce black, flake8, and mypy on CI.
- Simplify `platform.XXX` calls. As far as I know these can't raise an exception in Python 3.
- Simplify `EngineAPIResource` constructor and remove its unused `retrieve` method.
@rachellim rachellim requested review from hallacy and madeleineth June 11, 2021 19:31
@rachellim rachellim merged commit 40c32f9 into main Jun 11, 2021
@rachellim rachellim deleted the rachel/cleanup branch June 11, 2021 20:46
cgayapr pushed a commit to cgayapr/openai-python that referenced this pull request Dec 14, 2024
* python 3.6 + typing (openai#25)

- Formally require Python 3.6 or later. This never worked under Python 2.7.
- Drop now-unnecessary `__future__` and `six` references.
- Use `py.typed` to declare that we support type hints.
- Fix a variety of mypy errors.
- Don't use star imports, so that other packages can tell if they're making an invalid reference.
- Drop support for non-`requests` HTTP clients.
- Drop `EngineAPIResource.update`; it could never have worked.

Tested against primaryapi and engineapi in staging, and it doesn't break them. After this, `mypy ./openai` runs clean.

* delete unused code (openai#27)

- Delete `ListObject`. It has some typing errors that suggest it never worked, and it is unused as far as I can tell.
- Delete `VerifyMixin`. It is unused.
- Delete `CardError`. It is unused and smells of rotten pasta.
- Delete `OpenAIErrorWithParamCode`, which only has one subclass, `InvalidRequestError`, and make `InvalidRequestError` a direct subclass of `OpenAIError`. Currrently, `OpenAIErrorWithParamCode` depends on the internal structure of `InvalidRequestError` so they're not independent.

* boring formatting and typing fixes (openai#26)

These are another step towards being able to enforce black, flake8, and mypy on CI.

* fix more typing issues in prep for CI (openai#28)

- Simplify `platform.XXX` calls. As far as I know these can't raise an exception in Python 3.
- Simplify `EngineAPIResource` constructor and remove its unused `retrieve` method.

* Update readme, bump version

* typo fix

Co-authored-by: Madeleine Thompson <[email protected]>
Co-authored-by: Madeleine Thompson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants