fix(embeddings): raise error message on missing data #2369
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcf2023 to
03feca5
Compare
|
Thanks for the PR, was this happening against a custom server? or the official OpenAI API? |
|
This happened against a custom vLLM server where just the model selection was wrong and it took long to find the problem without a message like this. |
RobertCraigie
requested changes
Jul 10, 2025
4ec1664 to
408abc7
Compare
I had a setup where my embedding model didn't reply properly and had a really hard time figuring out where "NoneType object is not iterable" comes from. With this error message, it should be easier to find the problem.
408abc7 to
d965927
Compare
|
@RobertCraigie Thanks for the review, I implemented also for the async client and changed the implementation so it should pass the linter (without an exception) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a setup where my embedding model didn't reply properly and had a really hard time figuring out where
"NoneType object is not iterable" comes from.
With this error message, it should be easier to find the problem.
Possibly this is a bad place to create this exception, so please hint me into the right direction. I just
debugged my problem down to this place.