Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pass api params into prepare_request #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

tanpinxi
Copy link
Contributor

Fix for issue #303

Originally, the Audio endpoint does not pass the api_key into the request

import openai
key = ...
with open("sample.wav", "rb") as audio_file:
    transcript = openai.Audio.transcribe("whisper-1", audio_file, api_key=key)

# openai.error.AuthenticationError: No API key provided. 

This fixes the error by passing the api_key param, as well as other api-related params, into the _prepare_request method.

import openai
key = ...
with open("sample.wav", "rb") as audio_file:
    transcript = openai.Audio.transcribe("whisper-1", audio_file, api_key=key)

# <OpenAIObject>

@hallacy hallacy requested a review from mpokrass March 30, 2023 04:37
@mpokrass mpokrass removed their request for review April 4, 2023 16:03
@hallacy
Copy link
Collaborator

hallacy commented Apr 8, 2023

Closing this because #369 fixed it

@hallacy hallacy closed this Apr 8, 2023
safa0 pushed a commit to safa0/openai-agents-python that referenced this pull request Apr 27, 2025
We don't really need mypy on 3.9 (unit tests would catch any real
issues), and it causes issues with the rest of this stack.


---
[//]: # (BEGIN SAPLING FOOTER)
* openai#324
* openai#322
* openai#321
* openai#320
* __->__ openai#319
safa0 pushed a commit to safa0/openai-agents-python that referenced this pull request Apr 27, 2025
### Summary:
1. Add the MCP dep for python 3.10, since it doesn't support 3.9 and
below
2. Create MCPServer, which is the agents SDK representation of an MCP
server
3. Create implementations for HTTP-SSE and StdIO servers, directly
copying the [MCP SDK
example](https://github.com/modelcontextprotocol/python-sdk/blob/main/examples/clients/simple-chatbot/mcp_simple_chatbot/main.py)
4. Add a util to transform MCP tools into Agent SDK tools

Note: I added optional caching support to the servers. That way, if you
happen to know a server's tools don't change, you can just cache them.

### Test Plan:

Checks pass. I added tests at the end of the stack.

--- 

openai#324
openai#322
openai#321
-> openai#320
openai#319
safa0 pushed a commit to safa0/openai-agents-python that referenced this pull request Apr 27, 2025
### Summary:
This enables users to **use** MCP inside the SDK.
1. You add a list of MCP servers to `Agent`, via `mcp_server=[...]`
2. When an agent runs, we look up its MCP tools and add them to the list
of tools.
3. When a tool call occurs, we call the relevant MCP server.

Notes:
1. There's some refactoring to make sure we send the full list of tools
to the Runner/Model etc.
2. Right now, you could have a locally defined tool that conflicts with
an MCP defined tool. I didn't add errors for that, will do in a
followup.

### Test Plan:
See unit tests. Also has an end to end example next PR.

---
[//]: # (BEGIN SAPLING FOOTER)
* openai#324
* openai#322
* __->__ openai#321
* openai#320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants