-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add Azure AD authentication support #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorinsuciu-msft
approved these changes
May 25, 2022
hallacy
reviewed
May 25, 2022
andreasjl
reviewed
May 31, 2022
…dd_azure_ad_authentication
hallacy
approved these changes
Jun 23, 2022
@sorinsuciu-msft I think this looks good. Good to merge from your side? |
GinoBacallao
pushed a commit
to GinoBacallao/openai-python
that referenced
this pull request
Jun 24, 2022
* Make embeddings_utils be importable (openai#104) * Make embeddings_utils be importable * Small tweaks to dicts for typing * Remove default api_prefix and move v1 prefix to default api_base (openai#95) * make construct_from key argument optional (openai#92) * Split search.prepare_data into answers/classifications/search versions (openai#93) * Break out prepare_data into answers, classifications, and search * And cleaned up CLI * Validate search files (openai#69) * Add validators for search files * Clean up fields Co-authored-by: kennyhsu5 <[email protected]> Co-authored-by: Madeleine Thompson <[email protected]>
Yes, looks good to me, thank you. |
cgayapr
pushed a commit
to cgayapr/openai-python
that referenced
this pull request
Dec 14, 2024
* Make embeddings_utils be importable (openai#104) * Make embeddings_utils be importable * Small tweaks to dicts for typing * Remove default api_prefix and move v1 prefix to default api_base (openai#95) * make construct_from key argument optional (openai#92) * Split search.prepare_data into answers/classifications/search versions (openai#93) * Break out prepare_data into answers, classifications, and search * And cleaned up CLI * Validate search files (openai#69) * Add validators for search files * Clean up fields Co-authored-by: kennyhsu5 <[email protected]> Co-authored-by: Madeleine Thompson <[email protected]>
cgayapr
pushed a commit
to cgayapr/openai-python
that referenced
this pull request
Dec 14, 2024
* Add Azure AD authentication support * Add azure_ad code examples * Remove debug print statement * Bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for authentication using azure active directory.
For azure_ad authentication the api_type needs to be set to "azure_ad" (or alternatively "azuread") and the credentials token needs to be passed to api_key. Similar to the azure key-based authentication, the api_version has to be specified