Refactor as a single-class bundle #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effd607 to
a128e36
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the OpenAI Symfony bundle from a traditional bundle structure to a single-class bundle using Symfony's AbstractBundle. It removes support for older Symfony versions (5.4, 6.3) and adds support for Symfony 8.0, while introducing additional configuration options for project and base_uri.
Key changes:
- Consolidates bundle functionality into a single
OpenAIBundleclass extendingAbstractBundle - Adds
projectandbase_uriconfiguration options - Updates Symfony version constraints to support only 6.4, 7.3+, and 8.0
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/OpenAIBundle.php | Refactored to extend AbstractBundle with embedded configuration and service registration |
| tests/OpenAIBundleTest.php | New integration test using Symfony kernel to test the complete bundle |
| src/DependencyInjection/OpenAIExtension.php | Removed - functionality moved to OpenAIBundle |
| src/DependencyInjection/Configuration.php | Removed - configuration moved to OpenAIBundle |
| src/Resources/config/services.php | Removed - service configuration moved to OpenAIBundle |
| tests/DependencyInjection/OpenAIExtensionTest.php | Removed - replaced by integration test |
| composer.json | Updated Symfony version constraints and dev dependencies |
| .github/workflows/tests.yml | Updated CI matrix to test only supported Symfony versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
projectandbase_uri.Related: