support conditional ts enums #2433
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds support (via optional flag) for generating TS Enums only where there is relevant metadata.
TS Enums can provide useful mappings in specific circumstances:
but is also entirely redundant in many others:
This PR provides an optional
--conditional-enums
flag to only create TS Enums where relevant mapping metadata has been explicitly added:Converts to
The particular use case I am targeting is for established code bases that rely 95% on simple type unions, but may occasionally wish to store enum mappings in OAPI where appropriate.
This feature would assist in cases such as #941 and #2366.
How to Review
Prepare an OAPI schema with two kinds of enums, one with metadata and one without (see above
Status
/StatusEnum
example).Test generating typings with the
enum
flag enabled, and then toggle theconditionalEnums
to compare the differences in result.Checklist
docs/
updated (if necessary)pnpm run update:examples
run (only applicable for openapi-typescript)