fix(security): resolve local auth for gateway probe #1011
Merged
+145
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix inverted auth resolution logic in
maybeProbeGatewaythat causedclawdbot security audit --deepto fail with "unauthorized" when connecting to a local gateway.The Bug
In
src/security/audit.ts, the auth selection condition was inverted:For local mode (
gateway.modeundefined or"local"):isRemoteMode = falseremoteUrlMissing = false(sinceisRemoteMode && !remoteUrlRaw)resolveAuth("remote")which returnsundefinedtokenThe Fix
Testing
pnpm lint- 0 warnings, 0 errorspnpm test src/security/audit.test.ts- 20 tests passclawdbot security audit --deep- works without "unauthorized" errorAI-Assisted PR 🤖