fix: thread accountId through subagent announce delivery chain #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openclaw#1058 When a subagent completes, the announce flow now properly routes delivery through the correct channel account (e.g., WhatsApp account 'kev' instead of falling back to 'default'). Changes: - sessions-spawn-tool: accept agentAccountId, pass to registry - subagent-registry: store requesterAccountId in run record - subagent-announce: pass channel + accountId to gateway agent call - gateway agent handler: accept accountId param, use for delivery - delivery.ts: use opts.accountId with session fallback - agent schema: add accountId to AgentParamsSchema
Contributor
|
Closed — fix landed on main.
Thanks @adam91holt — credited in CHANGELOG and as co-author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1058
Summary
When a subagent completes, the announce flow now properly routes delivery through the correct channel account (e.g., WhatsApp account
kevinstead of falling back todefault).Problem
The announce delivery was failing with:
accountIdwas not being threaded through the subagent spawn → announce → delivery chain.Solution
Thread
accountIdthrough the entire lifecycle:sessions-spawn-tool.ts: AcceptagentAccountId, pass toregisterSubagentRun()subagent-registry.ts: StorerequesterAccountIdin run record, pass to announce flowsubagent-announce.ts: Passchannel+accountIdto gateway agent callgateway/agent.ts: AcceptaccountIdparam, resolve with session fallbackdelivery.ts: Useopts.accountIdwith session-based fallbackagent schema: AddaccountIdtoAgentParamsSchemaTesting
Tested manually on WhatsApp:
kev)