fix: use session label as fallback in session switcher #1124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When displayName is not set, fall back to session.label for better visibility in the session switcher UI.
Fixes TS18047 error where 'progress' is possibly null within the self-referential object literal.
Contributor
|
Thanks! I landed this directly on main with a centralized fix in sessions.list (label fallback for displayName), added a regression test, and cleaned up the memory progress reporter. Commit: 9d9fff2 (co-authored-by: @abdaraxus). Closing this PR as superseded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
displayNameis not set, fall back tosession.labelfor better visibility in the session switcher UI.This makes spawned sub-agent sessions (which use
label) display their descriptive names in the session list instead of just the session key.