-
Notifications
You must be signed in to change notification settings - Fork 15.7k
feat(slack): add HTTP webhook mode #1143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements Slack URL verification for webhook setup: - isUrlVerification type guard - handleUrlVerification returns challenge string - SlackChallengeEvent interface Part of: slack-http-webhook-mode feature
Implements HMAC-SHA256 signature verification per Slack spec: - Replay protection (5-minute timestamp window) - Constant-time comparison via timingSafeEqual - JSDoc documentation Part of: slack-http-webhook-mode feature
Adds new config fields to SlackConfigSchema: - mode: 'socket' | 'http' (default: socket) - signingSecret: string for HTTP webhook verification - webhookPath: string for webhook endpoint (default: /slack/events) Includes validation: mode='http' requires signingSecret. Part of: slack-http-webhook-mode feature
Implements main HTTP request handler for Slack webhooks: - createSlackHttpHandler factory function - Raw body reading for signature verification - Header extraction for x-slack-signature/x-slack-request-timestamp - URL verification challenge handling - Immediate 200 acknowledgment (Slack <3s requirement) - Async event dispatch via queueMicrotask - Barrel export in index.ts Part of: slack-http-webhook-mode feature
Contributor
|
Hey J! Did you test this, does this work well? |
steipete
added a commit
that referenced
this pull request
Jan 18, 2026
Co-authored-by: Jonathan Rhyne <[email protected]>
Contributor
steipete
added a commit
that referenced
this pull request
Jan 18, 2026
Co-authored-by: Jonathan Rhyne <[email protected]>
rsneh
pushed a commit
to rsneh/clawdbot
that referenced
this pull request
Jan 21, 2026
…jdrhyne Co-authored-by: Jonathan Rhyne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds HTTP webhook mode for Slack integration, enabling serverless deployments without Socket Mode.
Changes
src/slack/http/signature.ts) — HMAC-SHA256 with replay protectionsrc/slack/http/challenge.ts) — Slack URL verificationsrc/slack/http/events.ts) — Request processing with immediate 200 ACKsrc/slack/http/dispatch.ts) — Routes HTTP events to handlersmode,signingSecret,webhookPathfieldsTests
signature.test.ts— 117 lines, covers valid/invalid signatures, replay, edge caseschallenge.test.ts— 36 lines, covers type guard and challenge echoevents.test.ts— 155 lines, integration tests with mocked req/resUsage
Checklist