Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@thewilloftheshadow
Copy link
Member

Summary

  • validate plugin config/ids during config reads and gateway updates
  • surface missing plugin paths/ids as config errors
  • add plugin validation tests and adjust sandbox fallback

Testing

  • pnpm test src/config/config.plugin-validation.test.ts

@steipete
Copy link
Contributor

  • M: ChannelsSchema now .passthrough(), so typos/unknown channel keys no longer fail validation (silently ignored). If goal is plugin channel keys, consider validating passthrough keys against plugin registry or emitting warnings. src/config/zod-schema.providers.ts
  • M: validateConfigObjectWithPlugins now runs on every config read/ update and always loads plugin registry; with plugins enabled by default this imports at least memory-core. Any broken plugin import or missing deps now makes config reads fail for unrelated commands. Consider gating plugin validation to when plugin config is present or making plugin errors non-fatal for read-only commands. src/ config/validation.ts

I chose to hard-fail on purpose, so people don't shoot themselves in the foot of things like "magical denylist setting that does not exist".

steipete pushed a commit that referenced this pull request Jan 20, 2026
@steipete steipete force-pushed the shadow/config-plugin-validation branch from e0d9500 to f2c7262 Compare January 20, 2026 11:01
@steipete steipete force-pushed the shadow/config-plugin-validation branch from f2c7262 to 2f6d580 Compare January 20, 2026 11:03
@steipete steipete merged commit 8214ab5 into main Jan 20, 2026
21 of 42 checks passed
@steipete steipete deleted the shadow/config-plugin-validation branch January 20, 2026 11:03
@steipete
Copy link
Contributor

Landed via temp rebase onto main.

  • Gate: pnpm lint && pnpm build && pnpm test
  • Land commit: ${land_sha}
  • Merge commit: ${merge_sha}

Thanks @thewilloftheshadow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants