refactor/plugin boundary #1306
Closed
refactor/plugin boundary #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
steipete
commented
Jan 20, 2026
- Phase 0 + Review
- (Step 2) Phase 2 & 3 Complete + Reviewed
- Step 3 + Review
- Step 4 (Needs Review)
- Step 5 + Review
- feat: add new channel capabilities for editing, unsending, replying, effects, and group management
- feat: enhance BlueBubbles channel integration with new messaging target normalization and typing indicator improvements
- feat: improve BlueBubbles message action error handling and enhance channel action descriptions
- feat: enhance BlueBubbles message actions with support for message editing, reply metadata, and improved effect handling
- feat: add support for setting group icons in BlueBubbles, enhancing group management capabilities
- feat: update BlueBubbles documentation and code to clarify group icon handling and normalize chat identifiers
- feat: enhance BlueBubbles functionality by implementing macOS version checks for message editing and improving server info caching
- feat: enhance BlueBubbles group message handling by adding account-specific logging and improving typing signal conditions
- feat: enhance BlueBubbles messaging targets by adding support for UUID and hex chat identifiers, improving normalization and parsing functions
- feat: implement reply context handling in BlueBubbles messaging, enhancing message formatting and metadata resolution
- feat: improve BlueBubbles message processing by adding reply context formatting and enhancing message ID extraction from responses
- feat: refactor BlueBubbles media handling by introducing a dedicated media send function and optimizing message processing for media attachments
- feat: enhance BlueBubbles media and message handling by adding reply context support and improving outbound message ID tracking
- feat: add media size validation to BlueBubbles media handling, ensuring compliance with channel limits and improving error handling for oversized media
- feat: extend BlueBubbles attachment handling by adding support for reply context, allowing users to reference previous messages in media attachments
- refactor: improve error handling in embedded run payloads by clarifying conditions for user-facing error messages and updating test descriptions for typing behavior
- fix: remove unused typingSignals variable in get-reply-run
- fix: drop stray Peekaboo submodule
- refactor: extend channel plugin boundary
…effects, and group management
…et normalization and typing indicator improvements
…hannel action descriptions
…iting, reply metadata, and improved effect handling
…roup management capabilities
… handling and normalize chat identifiers
… checks for message editing and improving server info caching
…ecific logging and improving typing signal conditions
…D and hex chat identifiers, improving normalization and parsing functions
…ncing message formatting and metadata resolution
…formatting and enhancing message ID extraction from responses
…media send function and optimizing message processing for media attachments
…context support and improving outbound message ID tracking
…ng compliance with channel limits and improving error handling for oversized media
…ply context, allowing users to reference previous messages in media attachments
…ng conditions for user-facing error messages and updating test descriptions for typing behavior
PR SummaryIntroduces metadata-driven channel UI and a major BlueBubbles upgrade.
Written by Cursor Bugbot for commit 1ddf800. This will update automatically on new commits. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| cfg, | ||
| accountId, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Caption not passed to attachment API call
Medium Severity
The sendBlueBubblesMedia function receives a caption parameter but does not pass it to sendBlueBubblesAttachment. Instead, it sends a separate text message for the caption. However, sendBlueBubblesAttachment in attachments.ts explicitly supports the caption parameter and includes code to add it to the API request (lines 182-187). This results in two separate messages being sent (attachment + text) rather than one attachment with inline caption, creating suboptimal UX and leaving the caption handling code in sendBlueBubblesAttachment unused.
Additional Locations (1)
steipete
added a commit
that referenced
this pull request
Jan 20, 2026
Contributor
Author
11 tasks
Contributor
Author
|
Closing: changes from this branch are already on Main commit: fdb171c (refactor: centralize channel ui metadata). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.