feat(discord): add wildcard channel config support #1334
Closed
+43
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for '*' wildcard in Discord channel configuration,
matching the existing guild-level wildcard behavior.
This allows applying default channel settings (like autoThread)
to all channels without listing each one explicitly:
guilds:
'*':
channels:
'*': { autoThread: true }
Specific channel configs still take precedence over the wildcard.
16bcb71 to
7e71801
Compare
Contributor
Author
CI NoteThe failing checks (format, protocol, swiftlint) are pre-existing failures on main - see main CI run #21185760477. My changes (wildcard channel config) pass lint and tests locally:
The format/protocol/swift failures need to be fixed on main separately. |
Contributor
|
Thank you! Good find. Fix is suboptimal, will rewrite.
Proposed fix (shared, consistent):
|
Contributor
|
Landed on main with:
Notes: switched Discord wildcard handling to the shared channel match helper (matchSource now reports wildcard) and added a thread-path wildcard test. Changelog updated with thanks. |
Contributor
Contributor
Author
|
@steipete thanks you're right, should have checked other providers and shared wildcard logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for
*wildcard in Discord channel configuration, matching the existing guild-level wildcard behavior.Motivation
Currently, to apply settings like
autoThreadto all channels in a guild, you need to list each channel explicitly. This PR adds wildcard support so you can configure defaults for all channels:Specific channel configs still take precedence over the wildcard.
Changes
src/discord/monitor/allow-list.ts: Added wildcard fallback inresolveDiscordChannelConfigsrc/discord/monitor.test.ts: Added test for wildcard channel configTesting