Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BlueBubbles: short ID mapping, action resolution, and threading/typing fixes #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steipete merged 3 commits into from
Jan 21, 2026
Merged

BlueBubbles: short ID mapping, action resolution, and threading/typing fixes #1369

steipete merged 3 commits into from
Jan 21, 2026

Conversation

@tyler6204
Copy link
Member

@tyler6204 tyler6204 commented Jan 21, 2026 •
edited
Loading

  • Add short ID mapping + full GUID retention for BlueBubbles message context so actions survive restarts without bloating prompts.
  • Improve BlueBubbles action handling (react/edit/unsend/reply) and reply-to resolution, including media send and thread context.
  • Expand BlueBubbles chat target resolution (chat_identifier/chatId/chatGuid) and strengthen reply-context caching tests.
  • Refine typing behavior during tool execution and adjust threading tool context fallback.

@tyler6204
feat: implement short ID mapping for BlueBubbles messages and enhance…
b073dee 
… reply context caching

- Added functionality to resolve short message IDs to full UUIDs and vice versa, optimizing token usage.
- Introduced a reply cache to store message context for replies when metadata is omitted in webhook payloads.
- Updated message handling to utilize short IDs for outbound messages and replies, improving efficiency.
- Enhanced error messages to clarify required parameters for actions like react, edit, and unsend.
- Added tests to ensure correct behavior of new features and maintain existing functionality.
@tyler6204
feat: enhance message handling with short ID resolution and reply con…
7bfc32f 
…text improvements

- Implemented resolution of short message IDs to full UUIDs in both text and media sending functions.
- Updated reply context formatting to optimize token usage by including only necessary information.
- Introduced truncation for long reply bodies to further reduce token consumption.
- Adjusted tests to reflect changes in reply context handling and message ID resolution.
@tyler6204
feat: enhance message context with full ID support for replies and ca…
9b9bbae 
…ching

- Updated message processing to include full message IDs alongside short IDs for better context resolution.
- Improved reply handling by caching inbound messages, allowing for accurate sender and body resolution without exposing dropped content.
- Adjusted tests to validate the new full ID properties and their integration into the message handling workflow.
@tyler6204 tyler6204 changed the title BlueBubbles: short ID mapping with durable full GUIDs for replies and actions BlueBubbles: short ID mapping, action resolution, and threading/typing fixes Jan 21, 2026
@steipete
Copy link
Contributor

steipete commented Jan 21, 2026

Findings / improvements

  • Medium extensions/bluebubbles/src/actions.ts:146 + extensions/ bluebubbles/src/monitor.ts:122 — short IDs resolve globally, no account/chat guard. If a short ID from another account is used, it still resolves and gets sent with the current account credentials. Safer: include account/chat in the short‑ID map or reject short IDs not tied to current account; or require MessageSidFull for action paths.
  • Medium extensions/bluebubbles/src/actions.ts:146 + extensions/ bluebubbles/src/monitor.ts:122 — expired/evicted short IDs fall through silently and get sent to BlueBubbles as numeric strings. That likely fails with unclear errors. Suggest explicit error: “short id expired; use MessageSidFull”.
  • Low (behavior change) extensions/bluebubbles/src/monitor.ts:1373 — inbound cache now only after allowlist/mention gating. A later allowed reply to a previously dropped message won’t get reply context anymore. If that’s intended (privacy), fine; if not, cache before gating but redact body/sender for dropped content.
  • Low (docs) src/auto-reply/templating.ts adds MessageSidFull/ ReplyToIdFull but docs table not updated (docs/gateway/ configuration.md). Worth documenting new fields + short‑ID behavior.

Testing

  • Good: new unit tests in extensions/bluebubbles/src/monitor.test.ts, extensions/bluebubbles/src/send.test.ts, src/auto-reply/reply/ typing-mode.test.ts.
  • Missing: extensions/bluebubbles/src/actions.test.ts coverage for short‑ID resolution + toolContext fallback + “short‑ID not found” error path. Add 2–3 tests.

Extra code read

  • Checked extensions/bluebubbles/src/actions.test.ts, src/auto-reply/ reply/inbound-dedupe.ts, src/channels/conversation-label.ts for side‑effects.

Google / external check

  • Searched BlueBubbles docs: no explicit mention of chat_identifier/ chat GUID parsing or short‑ID patterns; only general Private API feature list. So can’t confirm the chat_identifier mapping from docs. (docs.bluebubbles.app (https://docs.bluebubbles.app/private-api?utm_source=openai))

steipete added a commit that referenced this pull request Jan 21, 2026
@steipete
fix: harden bluebubbles short ids and fetch wrapper (#1369) (thanks @…
56fab1d 
…tyler6204)
@steipete steipete merged commit c3adc50 into openclaw:main Jan 21, 2026
18 of 22 checks passed
steipete added a commit that referenced this pull request Jan 21, 2026
@steipete
fix: harden bluebubbles short ids and fetch wrapper (#1369) (thanks @…
cd25d69 
…tyler6204)
@steipete steipete mentioned this pull request Jan 21, 2026
Merged
@steipete
Copy link
Contributor

steipete commented Jan 21, 2026

Landed via temp rebase onto main.

  • Gate: pnpm lint && pnpm build && pnpm test
  • Land commit: 9b9bbae
  • Merge commit: c3adc50

Follow-up fixes landed in #1387.

Thanks @tyler6204!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tyler6204 @steipete