fix(agents): use alphanumeric-only tool call IDs for OpenRouter compatibility #1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Should we make this conditional? Does this even show up in session logs? Makes stuff hard to read. |
zerone0x
added a commit
to zerone0x/clawdbot
that referenced
this pull request
Jan 21, 2026
…/strict modes
- Add ToolCallIdMode type ('standard' | 'strict') for provider compatibility
- Standard mode (default): allows [a-zA-Z0-9_-] for readable session logs
- Strict mode: only [a-zA-Z0-9] for Mistral via OpenRouter
- Update sanitizeSessionMessagesImages to accept toolCallIdMode option
- Export ToolCallIdMode from pi-embedded-helpers barrel
Addresses review feedback on PR openclaw#1372 about readability.
Contributor
Author
|
Good call! I've refactored the sanitization to support two modes:
The This preserves readability by default while still fixing the Mistral/OpenRouter compatibility issue when strict mode is used. |
9cab74e to
867b60f
Compare
steipete
pushed a commit
to zerone0x/clawdbot
that referenced
this pull request
Jan 22, 2026
…/strict modes
- Add ToolCallIdMode type ('standard' | 'strict') for provider compatibility
- Standard mode (default): allows [a-zA-Z0-9_-] for readable session logs
- Strict mode: only [a-zA-Z0-9] for Mistral via OpenRouter
- Update sanitizeSessionMessagesImages to accept toolCallIdMode option
- Export ToolCallIdMode from pi-embedded-helpers barrel
Addresses review feedback on PR openclaw#1372 about readability.
steipete
added a commit
to zerone0x/clawdbot
that referenced
this pull request
Jan 22, 2026
…tibility Some providers like Mistral via OpenRouter require strictly alphanumeric tool call IDs. The error message indicates: "Tool call id was whatsapp_login_1768799841527_1 but must be a-z, A-Z, 0-9, with a length of 9." Changes: - Update sanitizeToolCallId to strip all non-alphanumeric characters (previously allowed underscores and hyphens) - Update makeUniqueToolId to use alphanumeric suffixes (x2, x3, etc.) instead of underscores - Update isValidCloudCodeAssistToolId to validate alphanumeric-only IDs - Update tests to reflect stricter sanitization Fixes openclaw#1359 Co-Authored-By: Claude <[email protected]>
…/strict modes
- Add ToolCallIdMode type ('standard' | 'strict') for provider compatibility
- Standard mode (default): allows [a-zA-Z0-9_-] for readable session logs
- Strict mode: only [a-zA-Z0-9] for Mistral via OpenRouter
- Update sanitizeSessionMessagesImages to accept toolCallIdMode option
- Export ToolCallIdMode from pi-embedded-helpers barrel
Addresses review feedback on PR openclaw#1372 about readability.
867b60f to
f5cec1d
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1359
Some providers like Mistral via OpenRouter require strictly alphanumeric tool call IDs. The error message indicates:
This PR updates the tool call ID sanitization to be more restrictive, using only alphanumeric characters (
[a-zA-Z0-9]) instead of the previous pattern that allowed underscores and hyphens ([a-zA-Z0-9_-]).Changes
sanitizeToolCallIdto strip all non-alphanumeric characters (previously replaced with underscores)makeUniqueToolIdto use alphanumeric suffixes (x2,x3, etc. andt<timestamp>) instead of underscoresisValidCloudCodeAssistToolIdto validate alphanumeric-only IDsTest plan
pnpm exec vitest run src/agents/tool-call-id.test.ts- all 4 tests passpnpm exec vitest run src/agents/pi-embedded-helpers.sanitizetoolcallid.test.ts- all 3 tests pass🤖 Generated with Claude Code