Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(node): handle invoke approvals and errors #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ngutman wants to merge 1 commit into from
Closed

fix(node): handle invoke approvals and errors #1394

ngutman wants to merge 1 commit into from

Conversation

@ngutman
Copy link
Contributor

@ngutman ngutman commented Jan 21, 2026

Summary

  • prompt on allowlist miss for mac node exec approvals and persist allowlist decisions
  • flatten node invoke error payload to avoid JSON encode failures
  • log gateway request encode failures for visibility

Testing

  • manual: ran exec commands; toggled exec approval between allowlist and always approve; toggled ask-on-allowlist-miss

User-facing changes

  • mac node now prompts on allowlist miss and honors allow/deny decisions
  • node invoke result errors no longer fail to encode (reduces timeouts)

@ngutman ngutman force-pushed the fix/mac-node-approvals branch from 5073e0b to 14b3c25 Compare January 21, 2026 18:50
@steipete steipete self-assigned this Jan 21, 2026
@steipete
Copy link
Contributor

steipete commented Jan 22, 2026

Landed via local integration + full gate (pnpm lint && pnpm build && pnpm test). Merged commits:

  • 1092b30 fix(node): handle invoke approvals and errors
  • 4997a5b fix: improve macOS exec approvals

@steipete steipete closed this Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steipete steipete

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ngutman @steipete