fix(exec): check allowlist before prompting for node host #1425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nullwas passed instead ofundefinedfor optional paramsProblem
The node host path was always prompting for approval when
ask=on-miss, even when the command was already in the allowlist. The gateway host path correctly checks the allowlist first, but the node host path was missing this check.Additionally, #1417 accidentally reverted the fix from #1414 by passing
nullinstead ofundefinedforresolvedPathandsessionKeyin the approval request params. TypeBoxType.Optional(Type.String())rejectsnull.Solution
Added allowlist check to node host path mirroring gateway behavior:
analyzeShellCommand()matchAllowlist()andisSafeBinUsage()Fixed
null→undefinedfor optional params in both node and gateway host pathsTest plan
🤖 Generated with Claude Code