fix: sanitize tool call text in sessions-helpers extractAssistantText #1456
+34
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds sanitization to extractAssistantText in sessions-helpers.ts to prevent tool call text from leaking to users. Previously, messages retrieved from chat history via sessions-helpers.ts could expose: - Minimax XML tool calls (<invoke>...</invoke>) - Downgraded tool call markers ([Tool Call: name (ID: ...)]) - Thinking tags (<think>...</think>) This fix: - Exports the stripping functions from pi-embedded-utils.ts - Adds a new sanitizeTextContent helper in sessions-helpers.ts - Updates extractAssistantText to sanitize before returning - Updates extractMessageText in commands-subagents.ts to sanitize Fixes clawdbot#1269 Co-Authored-By: Claude <[email protected]>
Contributor
|
This really needs upstreaming to pi-mono. |
steipete
added a commit
that referenced
this pull request
Jan 23, 2026
steipete
added a commit
that referenced
this pull request
Jan 23, 2026
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1269
Adds sanitization to
extractAssistantTextinsessions-helpers.tsto prevent tool call text from leaking to users. Previously, messages retrieved from chat history viasessions-helpers.tscould expose:<invoke>...</invoke>)[Tool Call: name (ID: ...)])<think>...</think>)Changes
stripMinimaxToolCallXml,stripDowngradedToolCallText,stripThinkingTagsFromText) frompi-embedded-utils.tssanitizeTextContenthelper insessions-helpers.tsthat chains the sanitization functionsextractAssistantTextinsessions-helpers.tsto sanitize text content before returningextractMessageTextincommands-subagents.tsto use the same sanitizationTest plan
pnpm lintpassespnpm test src/agents/pi-embedded-utils.test.tspasses (existing tests for the stripping functions)/subagents logoutput🤖 Generated with Claude Code