fix(ui): allow relative URLs in avatar validation #1457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The isAvatarUrl check only accepted http://, https://, or data: URLs,
but the /avatar/{agentId} endpoint returns relative paths like /avatar/main.
This caused local file avatars to display as text instead of images.
Fixes avatar display for locally configured avatar files.
The frontend fix alone wasn't enough because:
1. serveIndexHtml() was injecting the raw avatar filename into HTML
2. agent.identity.get RPC was returning raw filename, overwriting the
HTML-injected value
Now both paths resolve local file avatars (*.png, *.jpg, etc.) to the
/avatar/{agentId} endpoint URL.
Contributor
|
steipete
added a commit
that referenced
this pull request
Jan 22, 2026
steipete
added a commit
that referenced
this pull request
Jan 22, 2026
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Local file avatars configured in
identity.avatardisplay as text instead of images in the webchat UI.Root Cause (3-layer bug)
1. Frontend - URL validation too strict
isAvatarUrl()only acceptedhttp://,https://, ordata:URLs:2. Backend HTML injection
serveIndexHtml()injected the raw avatar filename into HTML instead of the resolved URL.3. Backend RPC
agent.identity.getreturned the raw filename, which overwrote the HTML-injected value when the frontend fetched identity.Fix
//avatar/{agentId}URL before injectionTesting
identity.avatar: "myavatar.png"in agent configRegression from #1329 refactor in 8544df3.