fix(exec): only set security=full when elevated mode is full #1616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(exec): only set security=full when elevated mode is full
Problem
When using
elevated ASKmode, the exec approval flow was being bypassed entirely. Commands likecrontabthat weren't on the allowlist would run without requiring approval.Root Cause
In
bash-tools.exec.tsline 794:This set
security = "full"for all elevated modes (ASK and FULL), not just FULL mode.Since
requiresExecApproval()only requires approval whensecurity === "allowlist":The approval check was always skipped in ASK mode because
securitywas"full"instead of"allowlist".Fix
Only set
security = "full"whenelevatedMode === "full":This allows ASK mode to properly enforce the approval flow for non-allowlisted commands.
Testing
npm run build)