fix: follow up config.patch restarts/docs/tests #1653
Conversation
PR SummaryFollow-up to harden and document
Written by Cursor Bugbot for commit c870568. This will update automatically on new commits. Configure here. |
|
Landed via squash merge onto main.
Thanks @Glucksberg! |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| expect(parsed.payload?.stats?.mode).toBe("config.patch"); | ||
| } catch { | ||
| expect(patchRes.ok).toBe(true); | ||
| } |
There was a problem hiding this comment.
E2E test catch block masks sentinel verification failures
Medium Severity
The test "writes config, stores sentinel, and schedules restart" has a catch block that silently passes when sentinel file verification fails. If fs.readFile throws (file doesn't exist, permissions error) or JSON.parse fails, the catch block falls back to expect(patchRes.ok).toBe(true) which was already verified on line 191. This means the test can pass even when the sentinel file is never written or contains incorrect content, defeating the purpose of verifying sentinel creation.
* fix: land config.patch restarts/docs/tests (openclaw#1624) (thanks @Glucksberg) * docs: update changelog entry for config.patch follow-up (openclaw#1653) (thanks @Glucksberg)
Summary
Testing