Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@steipete
Copy link
Contributor

Summary

Fixes a gap where link preview suppression was lost on the HTML parse fallback path. Also adds tests + docs entry.

Changes

  • Preserve link_preview_options on plain-text retry when HTML parsing fails
  • Add sendMessageTelegram tests for linkPreview config + fallback
  • Document channels.telegram.linkPreview in Telegram docs + gateway config snippet

Test plan

  • pnpm lint
  • pnpm build
  • pnpm test

@cursor
Copy link

cursor bot commented Jan 25, 2026

PR Summary

  • Telegram send: Always apply link_preview_options from channels.telegram.linkPreview (default true); preserved on plain‑text retry after HTML parse errors. Simplifies API by removing per‑send linkPreview option.
  • Tests: Add coverage for disabled previews and verify options persist on fallback.
  • Docs/Changelog: Add channels.telegram.linkPreview to Telegram/grammY docs, gateway config snippet, and CHANGELOG.
  • Auto‑reply: Introduce NoticeLevel with normalizeNoticeLevel and extractNoticeDirective for system notice toggles.

Written by Cursor Bugbot for commit 335be50. This will update automatically on new commits. Configure here.

@steipete steipete merged commit 6534017 into main Jan 25, 2026
42 of 43 checks passed
@steipete steipete deleted the fix/telegram-link-preview-fallback branch January 25, 2026 07:55
@steipete
Copy link
Contributor Author

Landed via squash on main.

  • Gate: pnpm lint && pnpm build && pnpm test
  • Merge commit: 6534017

Thanks @zerone0x!

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

rawLevel: extracted.rawLevel,
hasDirective: extracted.hasDirective,
};
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused extractNoticeDirective function never called anywhere

Low Severity

The extractNoticeDirective function, normalizeNoticeLevel function, and NoticeLevel type are exported but never imported or called from anywhere in the codebase. This appears to be unrelated code that was accidentally included in a PR about "honoring linkPreview on fallback" for Telegram. These additions serve no purpose in the current state and add dead code to the codebase.

Additional Locations (1)

Fix in Cursor Fix in Web

jaydenfyi pushed a commit to jaydenfyi/clawdbot that referenced this pull request Jan 25, 2026
* feat: add notice directive parsing

* fix: honor telegram linkPreview config (openclaw#1700) (thanks @zerone0x)
mcinteerj pushed a commit to mcinteerj/moltbot that referenced this pull request Jan 25, 2026
* feat: add notice directive parsing

* fix: honor telegram linkPreview config (openclaw#1700) (thanks @zerone0x)
rodrigouroz pushed a commit to rodrigouroz/moltbot that referenced this pull request Jan 26, 2026
* feat: add notice directive parsing

* fix: honor telegram linkPreview config (openclaw#1700) (thanks @zerone0x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants