-
Notifications
You must be signed in to change notification settings - Fork 15.7k
fix(telegram): honor linkPreview on fallback #1730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Summary
Written by Cursor Bugbot for commit 335be50. This will update automatically on new commits. Configure here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| rawLevel: extracted.rawLevel, | ||
| hasDirective: extracted.hasDirective, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused extractNoticeDirective function never called anywhere
Low Severity
The extractNoticeDirective function, normalizeNoticeLevel function, and NoticeLevel type are exported but never imported or called from anywhere in the codebase. This appears to be unrelated code that was accidentally included in a PR about "honoring linkPreview on fallback" for Telegram. These additions serve no purpose in the current state and add dead code to the codebase.
Additional Locations (1)
* feat: add notice directive parsing * fix: honor telegram linkPreview config (openclaw#1700) (thanks @zerone0x)
* feat: add notice directive parsing * fix: honor telegram linkPreview config (openclaw#1700) (thanks @zerone0x)
* feat: add notice directive parsing * fix: honor telegram linkPreview config (openclaw#1700) (thanks @zerone0x)
Summary
Fixes a gap where link preview suppression was lost on the HTML parse fallback path. Also adds tests + docs entry.
Changes
Test plan