Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: use exact match for win32 platform detection #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ymat19 wants to merge 1 commit into from
Closed

fix: use exact match for win32 platform detection #1760

ymat19 wants to merge 1 commit into from

Conversation

@ymat19
Copy link
Contributor

@ymat19 ymat19 commented Jan 25, 2026 •
edited
Loading

Summary

The previous check used includes("win") which incorrectly matched "darwin" (macOS) because it contains "win". This caused cmd.exe to be used on macOS instead of /bin/sh, resulting in spawn cmd.exe ENOENT errors.

Changes

  • Changed normalized.includes("win") to normalized === "win32"

Why win32 is safe

Per Node.js documentation, process.platform returns "win32" on Windows regardless of 32-bit or 64-bit architecture. This is a stable API.

Testing

  • Tested with local Clawdbot instance on macOS (darwin)
  • Verified /bin/sh is now correctly used instead of cmd.exe
  • Ran npm run lint - no warnings or errors
  • Windows testing not performed (no Windows environment available)

AI Disclosure

  • AI-assisted: Yes (Claude)
  • Degree of testing: Tested on macOS, not tested on Windows
  • I understand what the code does: The change ensures only Windows (win32) uses cmd.exe, while all other platforms use /bin/sh

fix: use exact match for win32 platform detection
ccf1920 
The previous check used includes("win") which incorrectly matched
"darwin" (macOS) because it contains "win". This caused cmd.exe to be
used on macOS instead of /bin/sh.
@ymat19 ymat19 marked this pull request as ready for review January 25, 2026 09:48
@steipete steipete self-assigned this Jan 25, 2026
steipete added a commit that referenced this pull request Jan 25, 2026
@steipete @ymat19
fix: treat Windows platform labels as Windows for node shell (#1760)
7a5e103 
Thanks @ymat19.

Co-authored-by: ymat19 <[email protected]>
@steipete
Copy link
Contributor

steipete commented Jan 25, 2026

Landed via rebase onto main.

  • Rebases PR onto current main.
  • Adjusts node shell platform detection to treat Windows labels as Windows, adds unit coverage, and updates changelog.

Commits:

Thanks @ymat19!

@steipete steipete closed this Jan 25, 2026
steipete added a commit to orlyjamie/clawdbot that referenced this pull request Jan 25, 2026
@steipete @ymat19
fix: treat Windows platform labels as Windows for node shell (opencla…
2d99ec3 
…w#1760)

Thanks @ymat19.

Co-authored-by: ymat19 <[email protected]>
mcinteerj pushed a commit to mcinteerj/moltbot that referenced this pull request Jan 25, 2026
@steipete @ymat19
fix: treat Windows platform labels as Windows for node shell (opencla…
0a7d541 
…w#1760)

Thanks @ymat19.

Co-authored-by: ymat19 <[email protected]>
rodrigouroz pushed a commit to rodrigouroz/moltbot that referenced this pull request Jan 26, 2026
@steipete @ymat19 @rodrigouroz
fix: treat Windows platform labels as Windows for node shell (opencla…
3b1d37a 
…w#1760)

Thanks @ymat19.

Co-authored-by: ymat19 <[email protected]>
@maccann-24 maccann-24 mentioned this pull request Jan 28, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steipete steipete

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ymat19 @steipete