fix: apply config.env before ${VAR} substitution #1813
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config loading was calling resolveConfigEnvVars() before applyConfigEnv(),
so environment variables defined in the config's `env` section weren't available
when ${VAR} references were being substituted.
This caused errors like "Missing env var MINIMAX_API_KEY" when the key was
defined in config.env but referenced via ${MINIMAX_API_KEY} in provider config.
Fix by calling applyConfigEnv() immediately after resolving $include directives,
before the env var substitution pass.
Co-Authored-By: Claude Opus 4.5 <[email protected]>
thewilloftheshadow
added a commit
that referenced
this pull request
Jan 26, 2026
Co-authored-by: SPANISH FLU <[email protected]>
Member
|
Squash-merged into
|
Member
|
Closed after squash-merge to main (commit 1b598ad). |
steipete
pushed a commit
to mertcicekci0/clawdbot
that referenced
this pull request
Jan 26, 2026
Co-authored-by: SPANISH FLU <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
envsection values are available during${VAR}substitutionresolveConfigEnvVars()ran beforeapplyConfigEnv(), causing "Missing env var" errors for vars defined in configProblem
When config has:
{ "env": { "MINIMAX_API_KEY": "sk-..." }, "models": { "providers": { "minimax": { "apiKey": "${MINIMAX_API_KEY}" } } } }The substitution failed because the
envsection wasn't applied toprocess.envyet.Test plan