feat(android): add password field to manual gateway settings #2227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds password authentication support for manual gateway connections in the Android app, allowing users to connect to password-protected gateways through the Advanced settings section.
Changes:
- Added encrypted storage for manual gateway password in SecurePrefs
- Implemented password selection logic in NodeRuntime that uses the manual password for manual endpoints and falls back to the stored gateway password otherwise
- Exposed password field through MainViewModel to the UI layer
- Added a password input field with masking in the Advanced settings section
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/android/app/src/main/java/com/clawdbot/android/SecurePrefs.kt | Adds encrypted storage for manualPassword with trimming, consistent with other manual gateway settings |
| apps/android/app/src/main/java/com/clawdbot/android/NodeRuntime.kt | Exposes manualPassword and implements conditional password logic for manual endpoint connections |
| apps/android/app/src/main/java/com/clawdbot/android/MainViewModel.kt | Passes through manualPassword state and setter from runtime to UI |
| apps/android/app/src/main/java/com/clawdbot/android/ui/SettingsSheet.kt | Adds password input field with PasswordVisualTransformation in the Advanced section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Closing due to merge conflicts. Please rebase on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a password field to the Android app's manual gateway settings, allowing users to connect to password-protected gateways.
Changes
manualPasswordstorageTesting
Tested locally with a password-protected gateway running in LAN mode.
Split from #2219 which contained unrelated changes.