Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(logging): migrate node-host and tailscale console calls to subsystem logger#23669

Closed
kevinWangSheng wants to merge 1 commit into
openclaw:mainfrom
kevinWangSheng:refactor/console-to-subsystem-logger
Closed

refactor(logging): migrate node-host and tailscale console calls to subsystem logger#23669
kevinWangSheng wants to merge 1 commit into
openclaw:mainfrom
kevinWangSheng:refactor/console-to-subsystem-logger

Conversation

@kevinWangSheng

@kevinWangSheng kevinWangSheng commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Change Type

  • Refactor

Scope

  • Gateway / orchestration

Security Impact

  • New permissions/capabilities? No
  • Secrets/tokens handling changed? No
  • New/changed network calls? No
  • Command/tool execution surface changed? No
  • Data access scope changed? No

Compatibility / Migration

  • Backward compatible? Yes
  • Config/env changes? No
  • Migration needed? No

Risks and Mitigations

  • Risk: Some debug output may no longer appear at default log level
    • Mitigation: This is intentional — PATH info should be behind verbose/debug level

🤖 Generated with Claude Code

Greptile Summary

Migrates the last remaining raw console.log/console.error calls in src/node-host/runner.ts and src/infra/tailscale.ts to the structured createSubsystemLogger() system, continuing the pattern established in PRs #22964 and #22906.

  • src/node-host/runner.ts: Three console.log/console.error calls (with eslint-disable comments) replaced with log.info() and log.warn() calls via a "node-host" subsystem logger. PATH info is now structured metadata instead of a raw string, and connection error/close messages use warn level.
  • src/infra/tailscale.ts: One console.log replaced with log.info() via a "tailscale" subsystem logger. Four console.error calls in the error path of ensureFunnel correctly migrated to runtime.error() (user-facing CLI output), preserving the existing runtime parameter available in that function's signature.
  • Both files now have zero raw console calls, and all new patterns are consistent with the established subsystem logger usage across the codebase.

Confidence Score: 5/5

  • This PR is safe to merge — it's a straightforward mechanical refactor with no behavioral changes to user-facing output.
  • Score of 5 reflects: (1) minimal, mechanical changes replacing raw console calls with established subsystem logger patterns, (2) consistent with existing codebase conventions, (3) user-facing CLI output via runtime.error() is preserved unchanged, (4) no remaining raw console calls in either file, (5) existing tests for ensureFunnel use mocked runtime objects that will work correctly with the new runtime.error() calls.
  • No files require special attention.

Last reviewed commit: 7b16206

(5/5) You can turn off certain types of comments like style here!

@openclaw-barnacle openclaw-barnacle Bot added size: XS agents Agent runtime and tooling labels Feb 22, 2026
@openclaw-barnacle

Copy link
Copy Markdown

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XS stale Marked as stale due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants