refactor(logging): migrate node-host and tailscale console calls to subsystem logger#23669
Closed
kevinWangSheng wants to merge 1 commit into
Closed
Conversation
…ubsystem logger Co-Authored-By: Claude Opus 4.6 <[email protected]>
f569ddd to
838a581
Compare
|
This pull request has been automatically marked as stale due to inactivity. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/node-host/runner.tsandsrc/infra/tailscale.tsuse rawconsole.log/console.errorcalls that bypass structured logging, leak PATH env info, and can't be filtered by log levelcreateSubsystemLogger()in node-host runner and tailscale modules, continuing the migration started in PRs refactor(logging): migrate non-agent internal console calls to subsystem logger #22964 and refactor(agents): migrate console.warn/error/info to subsystem logger #22906runtime.error()calls is preserved unchangedChange Type
Scope
Security Impact
Compatibility / Migration
Risks and Mitigations
🤖 Generated with Claude Code
Greptile Summary
Migrates the last remaining raw
console.log/console.errorcalls insrc/node-host/runner.tsandsrc/infra/tailscale.tsto the structuredcreateSubsystemLogger()system, continuing the pattern established in PRs #22964 and #22906.src/node-host/runner.ts: Threeconsole.log/console.errorcalls (witheslint-disablecomments) replaced withlog.info()andlog.warn()calls via a"node-host"subsystem logger. PATH info is now structured metadata instead of a raw string, and connection error/close messages usewarnlevel.src/infra/tailscale.ts: Oneconsole.logreplaced withlog.info()via a"tailscale"subsystem logger. Fourconsole.errorcalls in the error path ofensureFunnelcorrectly migrated toruntime.error()(user-facing CLI output), preserving the existingruntimeparameter available in that function's signature.consolecalls, and all new patterns are consistent with the established subsystem logger usage across the codebase.Confidence Score: 5/5
runtime.error()is preserved unchanged, (4) no remaining raw console calls in either file, (5) existing tests forensureFunneluse mockedruntimeobjects that will work correctly with the newruntime.error()calls.Last reviewed commit: 7b16206
(5/5) You can turn off certain types of comments like style here!