fix: guard channel-tools listActions against plugin crashes #2859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wraps plugin.actions.listActions() in a try/catch so a single broken channel plugin cannot crash the entire agent boot sequence. Errors are logged once per plugin+message (deduped) via defaultRuntime.error() and the call gracefully returns an empty array instead of propagating the exception. Fixes: 'Cannot read properties of undefined (reading listActions)' after the clawdbot→moltbot rename left some plugin state undefined.
fd930cc to
0776161
Compare
Member
Contributor
|
@thewilloftheshadow did you mean to pull the bitwarden skill in with this? |
Member
|
No, I thought I removed it in a local commit, but I guess I forgot to push that one before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After the
clawdbot→moltbotrename, some channel plugins can end up with undefined state during boot. Whenplugin.actions.listActions()is called on such a plugin, it throws:This crashes the entire agent before it can reply, showing the user:
Fix
plugin.actions.listActions()calls in a try/catch via a newrunPluginListActions()helperdefaultRuntime.error()listChannelSupportedActions()andlistAllChannelSupportedActions()Impact
Defensive fix — no behavior change when plugins work correctly. Prevents a single broken/misconfigured channel plugin from taking down the whole agent.