Fixes cron jobs #3335
Open
Fixes cron jobs #3335
+164
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Tried inside the terminal and telegram. |
Contributor
|
This PR may help with several open cron issues: Issues this could address:
Related PRs:
Could you clarify which specific cron bugs this addresses? Would help with issue triage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2323
Cron jobs seems to have broken after #1535
The reason seems to be an early return that was added in the PR above, that would not the
system eventsqueue clear ifHEARTBEAT.mdis empty.Cron jobs are pushed to system events when executed, and hence the change ensures that if there are pending system events they should be executed irrespective of the
heartbeat.mdfile being empty.