fix(plugins): follow symlinks in plugin and hook discovery #3564
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readdir entries report isDirectory()=false for symlinks, causing plugin discovery, hook discovery, and security audits to skip symlinked directories. Adding isSymbolicLink() checks lets symlinked packages be found correctly. Affected files: - src/plugins/discovery.ts (plugin/extension discovery) - src/hooks/workspace.ts (hook discovery) - src/security/audit-extra.ts (extension security audit) Useful when extensions or hooks are managed outside the workspace and symlinked in (e.g. from a shared development directory).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symlinked extension and hook directories weren't being discovered.
readdirwithwithFileTypesreturnsDirentobjects whereisDirectory()is false for symlinks, even when the target is a directory — so they get silently skipped.Added
isSymbolicLink()checks in three places:src/plugins/discovery.ts— plugin/extension discoverysrc/hooks/workspace.ts— hook discoverysrc/security/audit-extra.ts— extension security auditOther
isDirectory()calls insrc/either usefs.statSync(follows symlinks already) or operate on internal state dirs that wouldn't be symlinked. Dangling or non-directory symlinks are handled gracefully by existing null checks downstream (readPackageManifestreturns null on any failure).Related: #2961