Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(signal): add group-level allowlist support via groups config #4337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
derekross wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(signal): add group-level allowlist support via groups config #4337

derekross wants to merge 2 commits into from
+231 −3

Conversation

@derekross
Copy link

@derekross derekross commented Jan 30, 2026

Summary

Fixes #4336

  • Add channels.signal.groups.<groupId> config to allow specific Signal groups by ID
  • Groups listed in this config bypass the sender-level groupAllowFrom check
  • Matches the pattern used by Telegram and iMessage for group allowlists

Changes

  • Add SignalGroupConfig type and groups property to Signal config schema
  • Add SignalGroupSchema to Zod validation
  • Add resolveChannelGroupPolicy check in Signal event handler
  • Add tests for group-level allowlist functionality
  • Update docs to explain groupAllowFrom (senders) vs groups (group IDs)

Usage

{
  channels: {
    signal: {
      groupPolicy: "allowlist",
      groups: {
        "your-signal-group-id": {}  // Allow this specific group
      }
    }
  }
}

Testing

  • Added unit tests for group-level allowlist
  • Manually tested on live Signal instance

@derekross
fix(signal): add group-level allowlist support via groups config
c9359b8 
Signal's groupPolicy: allowlist was checking senders against groupAllowFrom,
but users expected to put group IDs there. This adds proper group-level
allowlisting via channels.signal.groups.<groupId>, matching the pattern
used by Telegram and iMessage.

When a group is explicitly listed in the groups config, it bypasses the
sender-level groupAllowFrom check, allowing all members of that group
to interact with the bot.

- Add SignalGroupConfig type and groups property to SignalAccountConfig
- Add resolveChannelGroupPolicy check before sender-level gating
- Add tests for group-level allowlist functionality
- Update docs to clarify groupAllowFrom vs groups config
@derekross
fix(signal): add groups schema to Zod validation
dd705e3 
The TypeScript type was added but the Zod runtime schema was missing,
causing config validation to reject the groups key.
@moltbot-barnacle moltbot-barnacle bot added docs Improvements or additions to documentation channel: signal Channel integration: signal labels Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

channel: signal Channel integration: signal docs Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Signal groupPolicy: allowlist doesn't work with group IDs in groupAllowFrom

1 participant

@derekross