fix: Telegram reconnect, rebrand compat, and update restore step #4369
+35
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add "timed out" to NETWORK_ERROR_SNIPPETS in monitor.ts so grammY's getUpdates timeout message triggers reconnection instead of exiting - Add "timed out" to RECOVERABLE_MESSAGE_SNIPPETS in network-errors.ts for defense in depth - Fix LEGACY_CLI_NAME from "moltbot" to "clawdbot" and fix duplicated regex alternations in cli-name.ts and command-format.ts so the legacy binary name is recognized in PATH - Remove restore control-ui step from update-runner.ts since dist/control-ui/ is no longer git-tracked (commit 615ccf6) - Remove :!dist/control-ui/ pathspec exclusion from update-check.ts dirty check since those files are now gitignored - Add test for grammY timeout message format Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
"timed out after 500 seconds"ongetUpdatestimeout — neitherisNetworkRelatedError()(checks"timeout") norisRecoverableTelegramNetworkError()matched"timed out", so the error was re-thrown and the channel exited permanently. Added"timed out"to both snippet arrays.LEGACY_CLI_NAMEwas set to"moltbot"(same asDEFAULT_CLI_NAME) instead of"clawdbot", and the regex alternations were duplicated(moltbot|moltbot)instead of(moltbot|clawdbot). The embedded agent'sexectool failed withcommand not foundin environments where onlyclawdbotis in PATH.dist/control-ui/was un-tracked from git (commit615ccf641) but the update runner still triedgit checkout -- dist/control-ui/, causing a failed step. The matching dirty-check exemption inupdate-check.tswas also dead code.Changes
src/telegram/monitor.ts"timed out"toNETWORK_ERROR_SNIPPETSsrc/telegram/network-errors.ts"timed out"toRECOVERABLE_MESSAGE_SNIPPETSsrc/telegram/network-errors.test.tssrc/cli/cli-name.tsLEGACY_CLI_NAMEto"clawdbot", fix regex alternationsrc/cli/command-format.ts(moltbot|moltbot)to(moltbot|clawdbot)src/infra/update-runner.tsrestore control-uistepsrc/infra/update-check.ts:!dist/control-ui/pathspec exclusionTest plan
npx vitest run src/telegram/network-errors.test.ts— 8/8 pass (includes new "timed out" test)npx vitest run src/infra/update-runner.test.ts— 8/8 passpnpm lint— 0 warnings, 0 errorspnpm build— succeeds🤖 Generated with Claude Code