fix: handle string thread_ts from Slack properly #4389
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue openclaw#4380: The queue drain logic was using typeof === 'number' to check for thread IDs, which fails for Slack where thread_ts is a string like '1737766124.329349'. Changed three occurrences: - Line 43: typeof threadId !== 'number' → threadId == null - Line 49: typeof threadId === 'number' → threadId != null - Line 75: typeof originatingThreadId === 'number' → originatingThreadId != null This allows Slack string thread IDs to be properly recognized while still filtering out undefined/null values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4380 - Slack thread_ts messages were being dropped because the queue drain logic used
typeof === 'number'to check for thread IDs.Problem
Slack thread_ts values are strings (e.g.,
'1737766124.329349'), not numbers. The original code:This caused valid Slack thread messages to be filtered out incorrectly.
Solution
Changed three occurrences in
src/auto-reply/reply/queue/drain.ts:typeof threadId !== 'number'→threadId == nulltypeof threadId === 'number'→threadId != nulltypeof originatingThreadId === 'number'→originatingThreadId != nullTesting
Notes
This is a straightforward type check fix - no behavioral changes for existing numeric thread IDs.